gh-157676: Fix KeyError in tkinter.simpledialog when a foreign window holds the grab - #157677
Merged
serhiy-storchaka merged 4 commits intoSep 29, 2026
Merged
Conversation
…window holds the grab _temp_grab_focus() used grab_current() and focus_get(), which raise KeyError for windows which were not created by tkinter, such as a native message box. Use Tcl window names instead.
The dialog can destroy a temporary default root, and then even "winfo" fails with "application has been destroyed".
On the Windows CI runners "focus -force" has no effect, because SetForegroundWindow() is refused for a background process.
The application can lose the focus when the dialog is destroyed, and "focus" without -force does not take it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_temp_grab_focus()usedgrab_current()andfocus_get(), which raiseKeyErrorfor windows which were not created by tkinter, such as a native message box. Use Tcl window names instead. Regression from #151848, not released.🤖 Generated with Claude Code